Skip to content

Commit

Permalink
make crash reporting boolean part of build script. add some logs. bum…
Browse files Browse the repository at this point in the history
…p version number.
  • Loading branch information
ahmedre committed Feb 18, 2014
1 parent dab1dc1 commit ae7b790
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 4 deletions.
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,18 @@ Open Source Projects Used

Changelog
---------
**version 2.5.1** (released 2/17/2014)
- minor fixes

**version 2.5.0** (released 2/10/2014)
- fixes for indonesian
- fix sdcard issue on 4.3+
- various bugfixes and improvements

**version 2.4.9** (released 12/21/2013)
- fix galaxy note 8 black bar issue
- various bugfixes and improvements

**version 2.4.8** (released 11/3/2013)
- fix numerous crashes related to search
- fix many various other crashes
Expand Down
5 changes: 5 additions & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ android {
}

buildTypes {
debug {
buildConfigField "boolean", "LOG_CRASHES", "false"
}

release {
buildConfigField "boolean", "LOG_CRASHES", "true"
runProguard true
proguardFile 'proguard.cfg'
signingConfig signingConfigs.release
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.quran.labs.androidquran" android:versionCode="250"
android:versionName="2.5.0"
package="com.quran.labs.androidquran" android:versionCode="251"
android:versionName="2.5.1"
android:installLocation="auto">

<supports-screens android:largeScreens="true" android:xlargeScreens="true" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
package com.quran.labs.androidquran.data;

import com.quran.labs.androidquran.BuildConfig;

public class Constants {
public static final boolean CRASH_REPORTING_ENABLED = false;
public static final boolean CRASH_REPORTING_ENABLED =
BuildConfig.LOG_CRASHES;

// Numerics
public static final int DEFAULT_NIGHT_MODE_TEXT_BRIGHTNESS = 255;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public boolean onCreate() {
@Override
public Cursor query(Uri uri, String[] projection, String selection,
String[] selectionArgs, String sortOrder) {
Crashlytics.log("uri: " + uri.toString());
switch (sURIMatcher.match(uri)) {
case SEARCH_SUGGEST:
if (selectionArgs == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ private SuraTimingDatabaseHandler(String path) throws SQLException {
} catch (SQLException se) {
Crashlytics.log("database at " + path +
(new File(path).exists() ? " exists" : " doesn't exist"));
throw se;
Crashlytics.logException(se);
mDatabase = null;
}
}

Expand Down

0 comments on commit ae7b790

Please sign in to comment.