Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select newly downloaded translation #609

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

raheelahmad
Copy link
Contributor

@raheelahmad raheelahmad commented Dec 19, 2023

This is currently being handled at the ViewModel level, but I could see this being done by TranslationsDownloader as well.

Fixes #206 .

Copy link
Collaborator

@mohamede1945 mohamede1945 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work, Raheel.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cc49b3c) 41.76% compared to head (0c4c617) 41.69%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ranslationsFeature/TranslationsListViewModel.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   41.76%   41.69%   -0.07%     
==========================================
  Files         505      505              
  Lines       19607    19631      +24     
==========================================
- Hits         8188     8186       -2     
- Misses      11419    11445      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit 4240803 into quran:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark newly downloaded translations as active
2 participants