Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI fixes #712

Merged
merged 2 commits into from
Oct 31, 2023
Merged

More CI fixes #712

merged 2 commits into from
Oct 31, 2023

Conversation

KitsuneRal
Copy link
Member

@KitsuneRal KitsuneRal commented Oct 31, 2023

  1. Upgrade SonarCloud GitHub Action to the next version that chooses Java 17 instead of Java 11 they are about to stop supporting.
  2. Fix build failures with Clang by working around ubuntu-latest runners have an incompatible combination of clang and libstdc++ actions/runner-images#8659

There's one more, sporadic, failure that started happening recently and this PR doesn't address it: sometimes sendFile test in Quotest fails to download the files in several threads. Either something is loose in the multithreaded Quotient::NetworkAccessManager code or the failure is due to the server responding 429 and Quotient::NAM not knowing what to do with it - I haven't checked yet.

@KitsuneRal KitsuneRal added the building/packaging Issues with CMake files or packaging label Oct 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KitsuneRal KitsuneRal merged commit 8c603ad into dev Oct 31, 2023
28 of 29 checks passed
@KitsuneRal KitsuneRal deleted the kitsune/ci-fixes-again branch October 31, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building/packaging Issues with CMake files or packaging
Projects
Status: 0.8 - Done
Development

Successfully merging this pull request may close these issues.

1 participant