Remove expand drop down #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not happy with that, as we have one argocd per cluster and git repos where all the config for all clusters is stored, that means we have one argo-diff action per cluster in that repo, its possible that 8 of those diff actions are commeting a diff for one commit (if the commit changes state on 8 clusters) in this case with a long diff (= 8 diff comments), this feels not readable anymore without having the diff hidden in an expand dropwdown if you really need or want this, i would vote for making this behavior configurable via input variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a more concise diff output, there's no need to hide the diff behind an expand button