Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): Lock amp optimizer to v2.8.0 🔨 #249

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

ags1773
Copy link
Contributor

@ags1773 ags1773 commented Jun 17, 2021

@ampproject/toolbox-optimizer version 2.8.1 throws the following error, so locking it to v2.8.0

Error: [object Object] is not a PostCSS plugin
    at Processor.normalize (/Users/amogh/work/qt/thequint-malibu/node_modules/postcss/lib/processor.es6:130:15)
    at new Processor (/Users/amogh/work/qt/thequint-malibu/node_modules/postcss/lib/processor.es6:38:25)
    at postcss (/Users/amogh/work/qt/thequint-malibu/node_modules/postcss/lib/postcss.es6:34:10)
    at module.exports (/Users/amogh/work/qt/thequint-malibu/node_modules/cssnano-simple/src/index.js:54:10)
    at Processor.normalize (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/node_modules/postcss/lib/processor.js:40:13)
    at new Processor (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/node_modules/postcss/lib/processor.js:9:25)
    at postcss (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/node_modules/postcss/lib/postcss.js:25:10)
    at SeparateKeyframes.transform (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/lib/transformers/SeparateKeyframes.js:146:36)
    at DomTransformer.transformTree (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/lib/DomTransformer.js:184:25)
    at DomTransformer.transformHtml (/Users/amogh/work/qt/thequint-malibu/node_modules/@ampproject/toolbox-optimizer/lib/DomTransformer.js:168:5)
    at ampStoryPageHandler (/Users/amogh/work/qt/thequint-malibu/node_modules/@quintype/framework/server/amp/handlers/story-page.js:119:27)

@ags1773
Copy link
Contributor Author

ags1773 commented Jun 17, 2021

@Jeevan-Kishore Jeevan-Kishore changed the title lock amp optimizer to v2.8.0 fix(optimizer): Lock amp optimizer to v2.8.0 🔨 Jun 17, 2021
@Jeevan-Kishore Jeevan-Kishore merged commit 7214af7 into master Jun 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the hotfix-toolbox-optimizer branch June 17, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants