Exit on refresh metadata error

quintoandar · May 21, 2018 · b4e58ee · b4e58ee
1 parent 2f1bada
commit b4e58ee
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "quintoandar-kafka",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "description": "Default Kafka NodeJS lib for QuintoAndar",
   "main": "src/main.js",
   "dependencies": {

diff --git a/src/node-kafka-consumer.js b/src/node-kafka-consumer.js
@@ -35,7 +35,7 @@ class KafkaConsumer {
   init() {
     this.consumer = new kafka.ConsumerGroupStream(this.configs, this.topics);
     this.consumer.on('error', (err) => {
-      logger.error(err);
+      logger.error('node-kafka error: ', err);
       process.exit(1);
     });
 
@@ -52,11 +52,13 @@ class KafkaConsumer {
     this.consumer.consumerGroup.client.refreshMetadata(
       this.consumer.consumerGroup.topics,
       (err) => {
-        if (err && err.name === 'BrokerNotAvailableError') {
-          logger.warn(err);
-          this.consumer.close(() => {
-            this.init();
-          });
+        if (err) {
+          logger.warn('Refresh metadata error: ', err);
+          if (err.name === 'BrokerNotAvailableError') {
+            this.consumer.close(() => {
+              process.exit(1);
+            });
+          }
         }
       }
     );

diff --git a/tests/node-kafka-consumer.test.js b/tests/node-kafka-consumer.test.js
@@ -154,9 +154,9 @@ describe('Refresh metadata', () => {
     consumer.consumer.close = jest.fn().mockImplementation((cb) => {
       cb();
     });
-    consumer.consumer.name = 'original-consumer';
+    global.process.exit = jest.fn();
     consumer.refreshMetadata();
-    expect(consumer.consumer.name).toBe(undefined);
+    expect(global.process.exit).toHaveBeenCalledWith(1);
     done();
   });
 });