-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify put object options #4274
Conversation
E botocore.exceptions.ClientError: An error occurred (404) when calling the HeadObject operation: Not Found
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## put-object-options #4274 +/- ##
======================================================
+ Coverage 38.42% 38.74% +0.32%
======================================================
Files 778 779 +1
Lines 34403 34582 +179
Branches 5424 5219 -205
======================================================
+ Hits 13218 13398 +180
- Misses 20006 20641 +635
+ Partials 1179 543 -636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- api/python/tests/manual/sse-policy.json: Language not supported
- api/python/tests/manual/sse-test.sh: Language not supported
Comments suppressed due to low confidence (2)
api/python/quilt3/data_transfer.py:355
- The removal of add_put_options_safely might lead to missing critical options for the upload process. Ensure that all necessary options are still being set correctly.
part = s3_client.upload_part(
api/python/quilt3/data_transfer.py:514
- The removal of add_put_options_safely might lead to missing critical options for the upload process. Ensure that all necessary options are still being set correctly.
part = s3_client.upload_part_copy(
…ata/quilt into verify-put-object-options
Testing branch