Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify put object options #4274

Merged
merged 38 commits into from
Dec 31, 2024
Merged

Conversation

drernie
Copy link
Member

@drernie drernie commented Dec 27, 2024

Testing branch

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.74%. Comparing base (cd62b51) to head (2ae1311).
Report is 1 commits behind head on put-object-options.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           put-object-options    #4274      +/-   ##
======================================================
+ Coverage               38.42%   38.74%   +0.32%     
======================================================
  Files                     778      779       +1     
  Lines                   34403    34582     +179     
  Branches                 5424     5219     -205     
======================================================
+ Hits                    13218    13398     +180     
- Misses                  20006    20641     +635     
+ Partials                 1179      543     -636     
Flag Coverage Δ
api-python 91.63% <100.00%> (+0.22%) ⬆️
catalog 16.87% <ø> (ø)
lambda 91.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drernie drernie requested a review from Copilot December 31, 2024 20:02
@drernie drernie self-assigned this Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • api/python/tests/manual/sse-policy.json: Language not supported
  • api/python/tests/manual/sse-test.sh: Language not supported
Comments suppressed due to low confidence (2)

api/python/quilt3/data_transfer.py:355

  • The removal of add_put_options_safely might lead to missing critical options for the upload process. Ensure that all necessary options are still being set correctly.
part = s3_client.upload_part(

api/python/quilt3/data_transfer.py:514

  • The removal of add_put_options_safely might lead to missing critical options for the upload process. Ensure that all necessary options are still being set correctly.
part = s3_client.upload_part_copy(
@drernie drernie merged commit 964ea70 into put-object-options Dec 31, 2024
37 checks passed
@drernie drernie deleted the verify-put-object-options branch December 31, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant