Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quilt3: add credential process #4157

Closed
wants to merge 1 commit into from
Closed

Conversation

sir-sigurd
Copy link
Member

Description

This allows using stack credentials with AWS CLI.

Add this to ~/.aws/config:

[profile quilt-stack]
credential_process = quilt3 get-credentials

Now you can use stack credentials with AWS CLI:

AWS_PROFILE=quilt-stack aws s3 ls s3://your-stack-bucket

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.16%. Comparing base (fddc672) to head (7090ae5).
Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
api/python/quilt3/main.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4157   +/-   ##
=======================================
  Coverage   38.16%   38.16%           
=======================================
  Files         725      725           
  Lines       33504    33511    +7     
  Branches     4960     4960           
=======================================
+ Hits        12786    12790    +4     
- Misses      19550    19553    +3     
  Partials     1168     1168           
Flag Coverage Δ
api-python 90.82% <57.14%> (-0.04%) ⬇️
catalog 11.32% <ø> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd requested a review from nl0 October 11, 2024 12:27
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@drernie
Copy link
Member

drernie commented Dec 24, 2024

@sir-sigurd Closing, since I'm assuming this is obsoleted by our get_boto3_session. Or would this help solve our "API Token" problem somehow?

@drernie drernie closed this Dec 24, 2024
@sir-sigurd
Copy link
Member Author

I'm assuming this is obsoleted by our get_boto3_session

it's not
see description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants