-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulator, Admin: UI for modifying tabulator configs #4135
Conversation
Co-authored-by: Alexei Mochalov <[email protected]>
…tdata/quilt into admin-bucket-page-long-query-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is good to go now. don't forget to revert the workflow change (and wait til the registry pr is in)
Thanks! |
This reverts commit 05296ad.
@fiskus how hard it would be to populate the config editor with some basic boilerplate when adding a new config? smth like: schema:
- name: column1 # specify the schema
type: Utf8
source:
type: quilt-packages
package_name: "" # specify a RegEx for matching packages
logical_key: ".*\\.csv$" # specify a RegEx for matching logical keys
parser:
format: csv # or parquet |
Easy, good idea Also, I moved
|
* master: (97 commits) Remove `<Delay />` component (#4132) rewrite SUMMARY (doc reorg) (#4149) Tabulator, Admin: UI for modifying tabulator configs (#4135) Bump debian from `1b0b790` to `3f9e536` in /lambdas/thumbnail (#4158) Bump debian from bullseye-20240904-slim to bullseye-20240926-slim in /lambdas/thumbnail (#4156) Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /catalog (#4151) Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /s3-proxy (#4152) Edit file / Edit with config helper (#4147) Fix "bad `setState()`" warning (#4150) Update dependency webpack to v5.94.0 [SECURITY] (#4125) Fix `ui.package_description` example (#4146) Bump urllib3 from 1.26.18 to 1.26.19 in /lambdas/s3select (#4140) Move bucket settings to a separate page (#4122) Bump debian from bullseye-20240812-slim to bullseye-20240904-slim in /lambdas/thumbnail (#4131) Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /catalog (#4133) Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /s3-proxy (#4134) Bump certifi from 2023.7.22 to 2024.7.4 in /lambdas/preview (#4130) Bump zipp from 3.15.0 to 3.19.1 in /lambdas/preview (#4129) Bump cryptography from 42.0.4 to 43.0.1 in /lambdas/indexer (#4128) Ignore line-length lint rule for CHANGELOG (#4127) ...
<TextEditor />
hardcoded height. Make props and look of an error similar to<M.TextField />
OnDirty
module based onReactProvider
andRF.FormSpy
to observe dirty states outsideRF.Form
<*Form />
components:<PrimaryForm />,
` etc.Add
page has a root<RF.Form>
and lists all form inside. There is a simple route guard on leaving the pageEdit
page lists all these forms wrapped with<*Card />
component each:<PrimaryCard />
,<MetadataCard />
etc.<RF.Form>
each, also adding form buttons viaStickyActions/CardActions
Edit bucket
Add bucket
List tables
Edit/Add tables