Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc number of search results is not available with secure search #4066

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

sir-sigurd
Copy link
Member

No description provided.

@sir-sigurd sir-sigurd requested a review from nl0 August 2, 2024 15:08
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.25%. Comparing base (7134f13) to head (a2e09f8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4066    +/-   ##
========================================
  Coverage   39.25%   39.25%            
========================================
  Files         775      775            
  Lines       35088    35088            
  Branches     5295     5094   -201     
========================================
  Hits        13774    13774            
- Misses      20117    20748   +631     
+ Partials     1197      566   -631     
Flag Coverage Δ
api-python 91.10% <ø> (ø)
catalog 14.70% <ø> (ø)
lambda 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sir-sigurd sir-sigurd requested a review from akarve August 2, 2024 20:19
@sir-sigurd
Copy link
Member Author

@nl0
this is still correct, right?

@nl0
Copy link
Member

nl0 commented Nov 21, 2024

@nl0 this is still correct, right?

yep

@sir-sigurd sir-sigurd enabled auto-merge November 21, 2024 15:48
@sir-sigurd sir-sigurd added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 6c164a9 Nov 21, 2024
39 checks passed
@sir-sigurd sir-sigurd deleted the search-results-number-docs branch November 21, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants