Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quilt3.admin: SSO permissions mapping #4065

Merged
merged 9 commits into from
Aug 13, 2024
Merged

quilt3.admin: SSO permissions mapping #4065

merged 9 commits into from
Aug 13, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Aug 1, 2024

TODO

  • Unit tests
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.47%. Comparing base (3768543) to head (754bd6b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4065      +/-   ##
==========================================
+ Coverage   38.33%   38.47%   +0.13%     
==========================================
  Files         720      723       +3     
  Lines       33143    33218      +75     
  Branches     4707     4879     +172     
==========================================
+ Hits        12706    12781      +75     
  Misses      19813    19813              
  Partials      624      624              
Flag Coverage Δ
api-python 90.85% <100.00%> (+0.10%) ⬆️
catalog 11.45% <ø> (ø)
lambda 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd requested a review from nl0 August 7, 2024 14:16
nl0
nl0 previously approved these changes Aug 7, 2024
@sir-sigurd sir-sigurd changed the title quilt3.admin: SSO config quilt3.admin: SSO permissions mapping Aug 12, 2024
@sir-sigurd sir-sigurd marked this pull request as ready for review August 12, 2024 15:27
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sir-sigurd sir-sigurd added this pull request to the merge queue Aug 13, 2024
@sir-sigurd sir-sigurd removed this pull request from the merge queue due to a manual request Aug 13, 2024
@sir-sigurd sir-sigurd enabled auto-merge August 13, 2024 13:37
@sir-sigurd sir-sigurd added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit a5d9238 Aug 13, 2024
39 checks passed
@sir-sigurd sir-sigurd deleted the sso-config branch August 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants