Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate third-party services #4040

Closed
wants to merge 1 commit into from
Closed

Enumerate third-party services #4040

wants to merge 1 commit into from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jul 1, 2024

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.43%. Comparing base (4304d70) to head (84c905e).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4040    +/-   ##
========================================
  Coverage   38.43%   38.43%            
========================================
  Files         718      718            
  Lines       33051    33051            
  Branches     4670     4842   +172     
========================================
  Hits        12704    12704            
  Misses      19723    19723            
  Partials      624      624            
Flag Coverage Δ
api-python 90.75% <ø> (ø)
catalog 11.50% <ø> (ø)
lambda 87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus
Copy link
Member Author

fiskus commented Oct 10, 2024

Adds additional burden for maintaining

@fiskus fiskus closed this Oct 10, 2024
@drernie drernie deleted the third-party-services branch December 26, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant