Use meta.validating instead of manually control state
#3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3994 +/- ##
========================================
Coverage 36.68% 36.69%
========================================
Files 724 724
Lines 32254 32247 -7
Branches 4608 4769 +161
========================================
Hits 11833 11833
+ Misses 19758 19252 -506
- Partials 663 1162 +499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fiskus
force-pushed
the
fix-re-render-component-during-validation
branch
from
586950c to
4136cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
Warning: Cannot update a component ('PackageCreationForm') while rendering a different component ('ForwardRef(Field)'). To locate the bad setState() call inside 'ForwardRef(Field)', follow the stack trace as described in https://reactjs.org/link/setstate-in-render