Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSify utils/Dialogs and some related code #3983

Merged
merged 6 commits into from
May 23, 2024
Merged

TSify utils/Dialogs and some related code #3983

merged 6 commits into from
May 23, 2024

Conversation

nl0
Copy link
Member

@nl0 nl0 commented May 23, 2024

Extracted from #3982

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 36.56%. Comparing base (883ee43) to head (f4bc8d3).

Files Patch % Lines
catalog/app/utils/Dialogs.tsx 0.00% 25 Missing ⚠️
...og/app/containers/Admin/RolesAndPolicies/Roles.tsx 0.00% 2 Missing ⚠️
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3983    +/-   ##
========================================
  Coverage   36.56%   36.56%            
========================================
  Files         724      724            
  Lines       32248    32248            
  Branches     4769     4605   -164     
========================================
  Hits        11793    11793            
- Misses      19790    19792     +2     
+ Partials      665      663     -2     
Flag Coverage Δ
api-python 90.95% <ø> (ø)
catalog 10.52% <0.00%> (ø)
lambda 87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nl0 nl0 marked this pull request as ready for review May 23, 2024 06:57
@nl0 nl0 requested a review from fiskus May 23, 2024 06:57
catalog/app/utils/Dialogs.tsx Show resolved Hide resolved
catalog/app/utils/Dialogs.tsx Show resolved Hide resolved
@nl0 nl0 changed the title TSify utils/dialogs and some related code TSify utils/Dialogs and some related code May 23, 2024
@nl0 nl0 added this pull request to the merge queue May 23, 2024
Merged via the queue into master with commit 9ea699f May 23, 2024
38 of 40 checks passed
@nl0 nl0 deleted the tsify-dialogs branch May 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants