Split the workflows into catalog.yml, client.yml, and lambdas.yml #3866
There are no files selected for viewing
|
There was a problem hiding this comment.
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,9 @@ | ||
| on: | ||
| push: | ||
| paths: | ||
| - '.github/workflows/catalog.yml' | ||
| - 'catalog/**' | ||
| - 'shared/**' | ||
| jobs: | ||
|
There was a problem hiding this comment. @nl0: does anything besides the catalog depend on this?
Comment on lines
+3
to
+6
There was a problem hiding this comment. I think that doesn't work well with required jobs (you can see them in repo settings -> branches -> master)
you can check registry workflow in enterprise for idea on how to implement filtering also I suggest testing this CI stuff in a fork |
||
| test-catalog: | ||
| runs-on: ubuntu-latest | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| on: | ||
| push: | ||
| paths: | ||
| - '.github/workflows/lambdas.yml' | ||
| - 'lambdas/**' | ||
| jobs: | ||
| linter: | ||
|
There was a problem hiding this comment. Instead of copy-paste you might want this: https://docs.github.com/en/actions/using-workflows/reusing-workflows |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.7' | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip setuptools | ||
| python -m pip install 'pylint==2.10.2' 'pycodestyle>=2.6.1' isort | ||
| - name: Run pylint | ||
| run: | | ||
| pylint $(find ./lambdas/ -name '*.py') | ||
| - name: Run pycodestyle | ||
| run: | | ||
| pycodestyle $(find ./lambdas/ -name '*.py') | ||
| - name: Run isort | ||
| run: | | ||
| isort --check --diff ./lambdas/ | ||
|
|
||
| test-lambda: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| path: | ||
| - access_counts | ||
| - es/indexer | ||
| - molecule | ||
| - pkgevents | ||
| - pkgpush | ||
| - pkgselect | ||
| - preview | ||
| - s3hash | ||
| - s3select | ||
| - shared | ||
| - status_reports | ||
| - tabular_preview | ||
| - transcode | ||
| python-version: ['3.8'] | ||
| include: | ||
| - path: thumbnail | ||
| python-version: '3.9' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| QUILT_DISABLE_USAGE_METRICS: true | ||
| PYTHONPATH: deps | ||
| JUPYTER_PATH: deps/share/jupyter # Jupyter is not smart enough to handle custom Python paths | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install dependencies | ||
| run: | | ||
| # Due to behavior change in pip>=23.1 installing tifffile==0.15.1 | ||
| # from thumbnail lambda fails whithout installed wheel. | ||
| # See https://github.com/pypa/pip/issues/8559. | ||
| python -m pip install wheel | ||
| if [ ${{ matrix.path }} == "shared" ] | ||
| python -m pip install -e lambdas/shared[tests] | ||
| then | ||
| python -m pip install -e lambdas/shared | ||
| python -m pip install -e lambdas/${{ matrix.path }} | ||
| fi | ||
| python -m pip install -r lambdas/${{ matrix.path }}/test-requirements.txt | ||
|
|
||
| # Try to simulate the lambda .zip file: | ||
| # - Use --no-deps to ensure that second-order dependencies are included in the requirements file | ||
| # - Remove "tests" directories | ||
| # - Run "strip" on shared libraries | ||
| python -m pip install -t deps --no-deps -r lambdas/${{ matrix.path }}/requirements.txt | ||
| find deps -name tests -type d -exec rm -r \{} \+ | ||
| find deps \( -name '*.so.*' -o -name '*.so' \) -type f -exec strip \{} \+ | ||
| - name: Pytest | ||
| run: | | ||
| pytest --cov=lambdas lambdas/${{ matrix.path }} | ||
| - uses: codecov/codecov-action@v3 | ||
| env: | ||
| LAMBDA: ${{ matrix.path }} | ||
| with: | ||
| flags: lambda | ||
| name: ${{ github.job }} | ||
| env_vars: LAMBDA | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to use
yamlextension as it's recommended in https://yaml.org/faq.html