Split the workflows into catalog.yml, client.yml, and lambdas.yml #3866
Conversation
It makes more sense than JS vs Python, and lets us filter by paths and skip unnecessary testing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ci_pylint_isort #3866 +/- ##
================================================
Coverage 35.59% 35.59%
================================================
Files 711 711
Lines 31347 31347
Branches 4681 4681
================================================
Hits 11157 11157
Misses 19034 19034
Partials 1156 1156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| paths: | ||
| - '.github/workflows/catalog.yml' | ||
| - 'catalog/**' | ||
| - 'shared/**' |
There was a problem hiding this comment.
@nl0: does anything besides the catalog depend on this?
| - '.github/workflows/lambdas.yml' | ||
| - 'lambdas/**' | ||
| jobs: | ||
| linter: |
There was a problem hiding this comment.
Instead of copy-paste you might want this: https://docs.github.com/en/actions/using-workflows/reusing-workflows
There was a problem hiding this comment.
we might want to use yaml extension as it's recommended in https://yaml.org/faq.html
There was a problem hiding this comment.
lint-docs job is not really related to catalog
| paths: | ||
| - '.github/workflows/catalog.yml' | ||
| - 'catalog/**' | ||
| - 'shared/**' |
There was a problem hiding this comment.
I think that doesn't work well with required jobs (you can see them in repo settings -> branches -> master)
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions
If a workflow is skipped due to branch filtering, path filtering, or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.
you can check registry workflow in enterprise for idea on how to implement filtering
also I suggest testing this CI stuff in a fork
|
Closing old Dima PRs. |
It makes more sense than JS vs Python, and lets us filter by paths and skip unnecessary testing.