Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min.io Support - User-Provided S3 Clients #3765

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kevinemoore
Copy link
Contributor

Description

Allow users to pass their own S3 clients for accessing specific buckets to support Min.io and passing in S3 credentials outside of environment variables and config files.

TODO: how will this support bucket-to-bucket copy across different clients?

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

To support Min.io and passing in S3 credentials, allow users to pass their own S3 clients for accessing specific buckets.

TODO: how will this support bucket-to-bucket copy across different clients?
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #3765 (80827f9) into master (6ba9401) will decrease coverage by 12.96%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3765       +/-   ##
===========================================
- Coverage   34.82%   21.86%   -12.96%     
===========================================
  Files         709      675       -34     
  Lines       31104    25306     -5798     
  Branches     4637     4637               
===========================================
- Hits        10831     5534     -5297     
+ Misses      19124    18623      -501     
  Partials     1149     1149               
Flag Coverage Δ
api-python ?
catalog 9.25% <ø> (ø)
lambda 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kevinemoore kevinemoore changed the title Allow setting bucket-specific s3 clients Min.io Support - User-Provided S3 Clients Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant