Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Display improvements #3734

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

JSON Display improvements #3734

wants to merge 4 commits into from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 25, 2023

  • Highlight clickable areas on hover
  • Make empty space non-clickable: it's not obvious what should happen on click
  • Move closing braces vertically aligned with opening braces

Clickable areas before:
Screenshot from 2023-09-25 13-52-29

Clickable areas after:
Screenshot from 2023-09-25 13-46-46

On hover:
https://github.com/quiltdata/quilt/assets/533229/83fda124-5cbc-4654-b941-14418e74f542

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus changed the title highlight clickable, make empty space non-clickable, move closing bra… JSON Display improvements Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.71%. Comparing base (45070e6) to head (b6811d4).

Files with missing lines Patch % Lines
catalog/app/components/JsonDisplay/JsonDisplay.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3734      +/-   ##
==========================================
- Coverage   37.72%   37.71%   -0.01%     
==========================================
  Files         766      766              
  Lines       35148    35150       +2     
  Branches     5190     4997     -193     
==========================================
  Hits        13258    13258              
- Misses      21282    21284       +2     
  Partials      608      608              
Flag Coverage Δ
api-python 91.00% <ø> (ø)
catalog 12.12% <0.00%> (-0.01%) ⬇️
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus requested a review from nl0 September 25, 2023 11:00
nl0
nl0 previously approved these changes Sep 25, 2023
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tho i feel like braces alignment became more confusing

@fiskus
Copy link
Member Author

fiskus commented Sep 25, 2023

braces alignment became more confusing

Ok, I'm not sure about this, so I'll revert it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants