Disable all actions by actions = false

quiltdata · Jun 14, 2024 · fc3cecf · fc3cecf
1 parent f7d45ba
commit fc3cecf
Show file tree

Hide file tree

Showing 4 changed files with 66 additions and 28 deletions.
diff --git a/catalog/app/utils/BucketPreferences/BucketPreferences.spec.ts b/catalog/app/utils/BucketPreferences/BucketPreferences.spec.ts
@@ -101,6 +101,14 @@ describe('utils/BucketPreferences', () => {
       `
       expect(() => parse(config)).toThrowError()
     })
+
+    it('Actions = false disables all actions', () => {
+      const config = dedent`
+            ui:
+                actions: False
+      `
+      expect(parse(config).ui.actions).toMatchSnapshot()
+    })
   })
 
   describe('extendDefaults', () => {

diff --git a/catalog/app/utils/BucketPreferences/BucketPreferences.ts b/catalog/app/utils/BucketPreferences/BucketPreferences.ts
@@ -79,7 +79,7 @@ export interface AthenaPreferences {
 }
 
 interface UiPreferencesInput {
-  actions?: Partial<ActionPreferences>
+  actions?: Partial<ActionPreferences> | false
   athena?: AthenaPreferences
   blocks?: Partial<BlocksPreferencesInput>
   defaultSourceBucket?: DefaultSourceBucketInput
@@ -175,6 +175,17 @@ function validate(data: unknown): asserts data is BucketPreferencesInput {
   if (errors.length) throw new bucketErrors.BucketPreferencesInvalid({ errors })
 }
 
+function parseActions(actions?: Partial<ActionPreferences> | false): ActionPreferences {
+  if (actions === false) {
+    return R.map(R.F, defaultPreferences.ui.actions)
+  }
+
+  return {
+    ...defaultPreferences.ui.actions,
+    ...actions,
+  }
+}
+
 function parseAthena(athena?: AthenaPreferencesInput): AthenaPreferences {
   const { defaultWorkflow, ...rest } = { ...defaultPreferences.ui.athena, ...athena }
   return {
@@ -266,6 +277,7 @@ export function extendDefaults(data: BucketPreferencesInput): BucketPreferences
   return {
     ui: {
       ...R.mergeDeepRight(defaultPreferences.ui, data?.ui || {}),
+      actions: parseActions(data?.ui?.actions),
       athena: parseAthena(data?.ui?.athena),
       blocks: parseBlocks(data?.ui?.blocks),
       packageDescription: parsePackages(

diff --git a/catalog/app/utils/BucketPreferences/__snapshots__/BucketPreferences.spec.ts.snap b/catalog/app/utils/BucketPreferences/__snapshots__/BucketPreferences.spec.ts.snap
@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`utils/BucketPreferences parse Actions = false disables all actions 1`] = `
+{
+  "copyPackage": false,
+  "createPackage": false,
+  "deleteRevision": false,
+  "openInDesktop": false,
+  "revisePackage": false,
+}
+`;
diff --git a/shared/schemas/bucketConfig.yml.json b/shared/schemas/bucketConfig.yml.json
@@ -36,34 +36,41 @@
           }
         },
         "actions": {
-          "type": "object",
-          "description": "Hide and show action buttons",
-          "properties": {
-            "createPackage": {
-              "default": true,
-              "description": "Hides buttons triggering Create Package dialog, both creating package from scratch and from directory",
-              "type": "boolean",
-              "examples": [true, false]
-            },
-            "deleteRevision": {
-              "default": true,
-              "description": "Hides buttons triggering Delete Package Revision dialog",
-              "type": "boolean",
-              "examples": [true, false]
-            },
-            "revisePackage": {
-              "default": true,
-              "description": "Hides button triggering Revise Package dialog",
-              "type": "boolean",
-              "examples": [true, false]
-            },
-            "copyPackage": {
-              "default": true,
-              "description": "Hides button triggering Push to Bucket dialog",
-              "type": "boolean",
-              "examples": [true, false]
+          "default": {
+            "createPackage": true,
+            "deleteRevision": true,
+            "revisePackage": true,
+            "copyPackage": true
+          },
+          "oneOf": [
+            { "type": "boolean" },
+            {
+              "type": "object",
+              "description": "Hide and show action buttons",
+              "properties": {
+                "createPackage": {
+                  "description": "Hides buttons triggering Create Package dialog, both creating package from scratch and from directory",
+                  "type": "boolean",
+                  "examples": [true, false]
+                },
+                "deleteRevision": {
+                  "description": "Hides buttons triggering Delete Package Revision dialog",
+                  "type": "boolean",
+                  "examples": [true, false]
+                },
+                "revisePackage": {
+                  "description": "Hides button triggering Revise Package dialog",
+                  "type": "boolean",
+                  "examples": [true, false]
+                },
+                "copyPackage": {
+                  "description": "Hides button triggering Push to Bucket dialog",
+                  "type": "boolean",
+                  "examples": [true, false]
+                }
+              }
             }
-          }
+          ]
         },
         "blocks": {
           "description": "Hide and show UI blocks in package detail page",