Don't show negative number as search result count (#4101)

quiltdata · Aug 19, 2024 · e54b483 · e54b483
1 parent 9fa0a4c
commit e54b483
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/catalog/app/containers/Search/ResultType.tsx b/catalog/app/containers/Search/ResultType.tsx
@@ -119,7 +119,7 @@ export default function ResultType() {
               <Icon resultType={v} />
             </M.ListItemIcon>
             <M.ListItemText primary={getLabel(v)} />
-            {total != null && (
+            {total != null && total >= 0 && (
               <M.ListItemSecondaryAction>
                 <M.Chip className={classes.chip} size="small" label={total} />
               </M.ListItemSecondaryAction>

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -24,6 +24,7 @@ Entries inside each section should be ordered by type:
 
 ## Catalog, Lambdas
 * [Fixed] **SECURITY**: Remove `polyfill.io` references ([#4038](https://github.com/quiltdata/quilt/pull/4038))
+* [Fixed] Don't show negative number as search result count, in particular don't show `-1` when `secure_search: True` ([#4101](https://github.com/quiltdata/quilt/pull/4101))
 * [Changed] Renamed "Admin settings" to "Admin" ([#4045](https://github.com/quiltdata/quilt/pull/4045))
 * [Changed] Hide "Add bucket" button for non-admin users from main landing page ([#4106](https://github.com/quiltdata/quilt/pull/4106))
 * [Added] Admin: Support SSO permissions mapping (SSO config editor, disable role assignment for SSO-mapped users) ([#4070](https://github.com/quiltdata/quilt/pull/4070), [#4097](https://github.com/quiltdata/quilt/pull/4097), [#4099](https://github.com/quiltdata/quilt/pull/4099))