Skip to content

Commit

Permalink
Confirm SSO config deletion (#4099)
Browse files Browse the repository at this point in the history
  • Loading branch information
fiskus authored Aug 16, 2024
1 parent 095dbc9 commit c960cd2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion catalog/app/containers/Admin/UsersAndRoles/SsoConfig.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as React from 'react'
import * as RF from 'react-final-form'
import * as M from '@material-ui/core'

import { useConfirm } from 'components/Dialog'
import Lock from 'components/Lock'
import { loadMode } from 'components/FileEditor/loader'
import { docs } from 'constants/urls'
Expand Down Expand Up @@ -89,8 +90,14 @@ function Form({
ssoConfig,
}: FormProps) {
const classes = useStyles()
const confirm = useConfirm({
title: 'You are about to delete SSO mapping config',
submitTitle: 'Delete',
onSubmit: (confirmed) => confirmed && onDelete(),
})
return (
<>
{confirm.render(<></>)}
<M.DialogTitle disableTypography>
<M.Typography variant="h5">SSO role mapping config</M.Typography>
</M.DialogTitle>
Expand Down Expand Up @@ -118,7 +125,7 @@ function Form({
</M.DialogContent>
<M.DialogActions>
<M.Button
onClick={onDelete}
onClick={confirm.open}
color="inherit"
disabled={submitting}
className={classes.delete}
Expand Down
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Entries inside each section should be ordered by type:
## Catalog, Lambdas
* [Fixed] **SECURITY**: Remove `polyfill.io` references ([#4038](https://github.com/quiltdata/quilt/pull/4038))
* [Changed] Renamed "Admin settings" to "Admin" ([#4045](https://github.com/quiltdata/quilt/pull/4045))
* [Added] Admin: Support SSO permissions mapping (SSO config editor, disable role assignment for SSO-mapped users) ([#4070](https://github.com/quiltdata/quilt/pull/4070), [#4097](https://github.com/quiltdata/quilt/pull/4097))
* [Added] Admin: Support SSO permissions mapping (SSO config editor, disable role assignment for SSO-mapped users) ([#4070](https://github.com/quiltdata/quilt/pull/4070), [#4097](https://github.com/quiltdata/quilt/pull/4097), [#4099](https://github.com/quiltdata/quilt/pull/4099))

# 6.0.0a5 - 2024-06-25
## Python API
Expand Down

0 comments on commit c960cd2

Please sign in to comment.