DOES download the specified path

quiltdata · Jan 24, 2024 · 61ec434 · 61ec434
1 parent ae51add
commit 61ec434
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## [0.7.6] 2024-01-10 UNOFFICIAL
 
+- Fix "&path=" Quilt+ URIs
 - Re-enable crash on failure
 
 ## [0.7.5] 2023-10-17

diff --git a/plugins/nf-quilt/src/main/nextflow/quilt/QuiltProduct.groovy b/plugins/nf-quilt/src/main/nextflow/quilt/QuiltProduct.groovy
@@ -145,6 +145,7 @@ ${nextflow}
             log.error("Exception: ${e}")
             print("FAILED: $pkg\n")
             e.printStackTrace()
+            /* groovylint-disable-next-line ThrowRuntimeException */
             throw new RuntimeException(e)
         }
         print("SUCCESS: $pkg\n")

diff --git a/plugins/nf-quilt/src/test/nextflow/quilt/jep/QuiltPackageTest.groovy b/plugins/nf-quilt/src/test/nextflow/quilt/jep/QuiltPackageTest.groovy
@@ -113,14 +113,13 @@ class QuiltPackageTest extends QuiltSpecification {
         def qpath = factory.parseUri(TEST_URL)
         def qpkg = qpath.pkg()
         Path outputFolder = pkg.packageDest()
-        Path readmeFile = outputFolder.resolve("README.md")
-        println("qpkg: ${qpkg}")
+        Path readmeFile = outputFolder.resolve('README.md')
+        println("qpkg: ${qpkg} -> ${qpath.localPath()} == ${readmeFile}")
 
         expect:
-        readmeFile == qpath.localPath()
         !qpath.isJustPackage()
-        !Files.isDirectory(qpath)
-        !Files.exists(readmeFile)
+        Files.isDirectory(outputFolder)
+        //!Files.exists(readmeFile)
 
         qpkg.install()
         Files.exists(qpath.localPath())
@@ -129,6 +128,7 @@ class QuiltPackageTest extends QuiltSpecification {
         Files.exists(readmeFile)
         Files.isRegularFile(readmeFile)
         Files.isReadable(readmeFile)
+        readObject(readmeFile).startsWith('# Quilt Smart Reports')
     }
 
     void 'should return null on failed install'() {