improve coverage

plugins/nf-quilt/src/main/nextflow/quilt/nio/QuiltFileSystemProvider.groovy

@@ -114,6 +114,9 @@ class QuiltFileSystemProvider extends FileSystemProvider implements FileSystemTr
         log.debug "QuiltFileSystemProvider.download: ${remoteFile} -> ${localDestination}"
         QuiltPath qPath = asQuiltPath(remoteFile)
         Path cachedFile = qPath.localPath()
+        /*
+         * UNUSED: QuiltPackage is always installed
+         *
         QuiltPackage pkg = qPath.pkg()
         if (!pkg.installed) {
             log.info "download.install Quilt package: ${pkg}"
@@ -124,6 +127,7 @@ class QuiltFileSystemProvider extends FileSystemProvider implements FileSystemTr
             }
             log.info "download.installed Quilt package to: $dest"
         }
+        */
 
         if (!Files.exists(cachedFile)) {
             log.error "download: File ${cachedFile} not found"

plugins/nf-quilt/src/test/nextflow/quilt/nio/QuiltFileSystemProviderTest.groovy

@@ -4,10 +4,12 @@ package nextflow.quilt.nio
 import nextflow.quilt.QuiltSpecification
 import groovy.transform.CompileDynamic
 import java.nio.file.Path
+import java.nio.file.Paths
 import java.nio.file.Files
 import java.nio.file.CopyOption
 import java.nio.file.StandardCopyOption
 import groovy.util.logging.Slf4j
+import org.codehaus.groovy.runtime.powerassert.PowerAssertionError
 
 /**
  *
@@ -24,6 +26,16 @@ class QuiltFileSystemProviderTest extends QuiltSpecification {
         provider.getScheme() == 'quilt+s3'
     }
 
+    void 'should error asQuiltPath with non-Quilt path'() {
+        given:
+        QuiltFileSystemProvider provider = new QuiltFileSystemProvider()
+        Path path = Paths.get('README.md')
+        when:
+        provider.asQuiltPath(path)
+        then:
+        thrown IllegalArgumentException
+    }
+
     // newDirectoryStream returns local path for read
     // newDirectoryStream returns package path for write
     // do we need a new schema for quilt+local?
@@ -58,4 +70,31 @@ class QuiltFileSystemProviderTest extends QuiltSpecification {
         Files.list(tempFolder).count() > 0
     }
 
+    void 'should error when copying from remote to local path'() {
+        given:
+        QuiltFileSystemProvider provider = new QuiltFileSystemProvider()
+        String filename = 'README.md'
+        Path remoteFile = QuiltPathFactory.parse('quilt+s3://quilt-example#package=examples%2fhurdat2&path=' + filename)
+        Path tempFolder = Files.createTempDirectory('quilt')
+        Path tempFile = tempFolder.resolve(filename)
+
+        when:
+        provider.copy(remoteFile, tempFile)
+
+        then:
+        thrown PowerAssertionError
+    }
+
+    void 'should do nothing when copying a path to itself'() {
+        given:
+        QuiltFileSystemProvider provider = new QuiltFileSystemProvider()
+        Path remoteFile = QuiltPathFactory.parse('quilt+s3://quilt-example#package=examples%2fhurdat2&path=README.md')
+
+        when:
+        provider.copy(remoteFile, remoteFile)
+
+        then:
+        Files.exists(remoteFile.localPath())
+    }
+
 }

plugins/nf-quilt/src/test/nextflow/quilt/nio/QuiltNioTest.groovy

@@ -79,8 +79,8 @@ class QuiltNioTest extends QuiltSpecification {
         text.startsWith('id')
     }
 
-    @IgnoreIf({ System.getProperty('os.name').toLowerCase().contains('windows') ||
-                System.getProperty('os.name').toLowerCase().contains('linux') })
+    @IgnoreIf({ System.getProperty('os.name').toLowerCase().contains('windows') })
+    @IgnoreIf({ System.getProperty('os.name').toLowerCase().contains('linux') })
     void 'should read file attributes'() {
         given:
         final start = System.currentTimeMillis()