Skip to content

Commit

Permalink
annotate with Java SDK terminology
Browse files Browse the repository at this point in the history
  • Loading branch information
drernie committed Aug 15, 2024
1 parent 65adfd8 commit 9ee44a3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions athena_federation/lambda_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def GetTableRequest(self) -> models.GetTableResponse:
)

## BEGIN: Placeholder methods for partition pruning/splits and spill requests
## Called `getPartitions(BlockWriter blockWriter, GetTableLayoutRequest request)` in Java SDK`
def GetTableLayoutRequest(self) -> models.GetTableLayoutResponse:
# The partition schema above was reused from CloudTrail example - we need to
# add (also?) the schema we want to pass back in a split?
Expand Down Expand Up @@ -97,6 +98,7 @@ def GetSplitsRequest(self) -> models.GetSplitsResponse:

## END: Unimplmented placehodlders

## Called `readWithConstraint(BlockWriter blockWriter, ReadRecordsRequest request)` in Java SDK
def ReadRecordsRequest(
self,
) -> Union[models.ReadRecordsResponse, models.RemoteReadRecordsResponse]:
Expand Down

0 comments on commit 9ee44a3

Please sign in to comment.