Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed ingest response #5635

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Detailed ingest response #5635

merged 4 commits into from
Jan 21, 2025

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Jan 15, 2025

Description

Currently ingest v2 only reports docs that couldn't be parsed correctly in metrics. This is even worse than ingest v1 that was just generating logs.

How was this PR tested?

Unit and integration tests.

@rdettai rdettai self-assigned this Jan 15, 2025
@rdettai rdettai requested a review from guilload January 15, 2025 17:49
@rdettai rdettai added the enhancement New feature or request label Jan 15, 2025
docs/reference/rest-api.md Outdated Show resolved Hide resolved
docs/reference/rest-api.md Outdated Show resolved Hide resolved
quickwit/quickwit-ingest/src/error.rs Outdated Show resolved Hide resolved
quickwit/quickwit-rest-client/src/rest_client.rs Outdated Show resolved Hide resolved
quickwit/quickwit-rest-client/src/rest_client.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/ingest_api/response.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/ingest_api/response.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/ingest_api/response.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/ingest_api/response.rs Outdated Show resolved Hide resolved
@rdettai rdettai force-pushed the detailed-ingest-resp branch from 7855e44 to 34061be Compare January 20, 2025 10:52
@rdettai rdettai force-pushed the detailed-ingest-resp branch from 34061be to b8fdd12 Compare January 20, 2025 12:57
@rdettai
Copy link
Collaborator Author

rdettai commented Jan 20, 2025

@guilload FYI I added the detailed-response flag to the CLI

@rdettai rdettai force-pushed the detailed-ingest-resp branch 2 times, most recently from cff8125 to d6be5c2 Compare January 20, 2025 15:00
@rdettai rdettai force-pushed the detailed-ingest-resp branch from d6be5c2 to 7e1a6cf Compare January 20, 2025 15:05
@rdettai rdettai merged commit 072d0fe into main Jan 21, 2025
4 checks passed
@rdettai rdettai deleted the detailed-ingest-resp branch January 21, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants