Add queueMicrotask #106
Merged
Add queueMicrotask #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
It would be good to test our implementation against https://github.com/web-platform-tests/wpt.
The main tests are in https://github.com/web-platform-tests/wpt/tree/master/html/webappapis/microtask-queuing and don't need a browser to run. There are more scattered across other directories.
Ref: #16
saghul
force-pushed
the
queue-microtask
branch
from
17b885f
to
5ba4c7f
Compare
bnoordhuis
approved these changes
Nov 21, 2023
|
I ported over some minimal test cases from WPT. More to come, we might want to think about some kind of test suite or are we ok with the current one? |
|
We may want to reconsider if/when we add more web platform APIs but until then I'm fine with cribbing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #16