Fix dspqueue_write_noblock race

Currenly check for wait_count is happening before updating the packet counters due to optimizations. This will result in HLOS not sending signal properly. This fix will ensure that wait_count is only checked after updating the packet counters. Signed-off-by: ANANDU KRISHNAN E <[email protected]>
quic · Nov 22, 2024 · 3fbe5e3 · 3fbe5e3
1 parent 05dbe07
commit 3fbe5e3
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/dspqueue/dspqueue_cpu.c b/src/dspqueue/dspqueue_cpu.c
@@ -1532,6 +1532,7 @@ AEEResult dspqueue_write_noblock(dspqueue_t queue, uint32_t flags,
   cache_flush_word(&dq->state->req_packet_count[q->id]);
   if (q->have_wait_counts) {
     // Only send a signal if the other end is potentially waiting
+    barrier_full();
     cache_invalidate_word(&read_state->wait_count);
     if (read_state->wait_count) {
       FARF(MEDIUM, "%s: Send signal", __func__);