Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix auto_flush_interval units in LineSenderFromConf #40

Merged
merged 1 commit into from
Jun 29, 2024
Merged

fix(client): fix auto_flush_interval units in LineSenderFromConf #40

merged 1 commit into from
Jun 29, 2024

Conversation

puzpuzpuz
Copy link
Collaborator

The auto_flush_interval unit was nanos while should be millis.

Also improves HTTP sender tests.

@puzpuzpuz puzpuzpuz added the bug Something isn't working label Jun 28, 2024
@puzpuzpuz puzpuzpuz self-assigned this Jun 28, 2024
@puzpuzpuz puzpuzpuz requested a review from sklarsa June 28, 2024 13:54
@puzpuzpuz
Copy link
Collaborator Author

@sklarsa could you take a look at this one?

sklarsa
sklarsa approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@sklarsa sklarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@puzpuzpuz puzpuzpuz merged commit 7cc3203 into main Jun 29, 2024
3 checks passed
@puzpuzpuz
Copy link
Collaborator Author

@sklarsa thanks for the review!

@puzpuzpuz puzpuzpuz deleted the better-tests branch June 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklarsa sklarsa sklarsa approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puzpuzpuz @sklarsa