Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Meteor 3 - wip #3

Closed
wants to merge 10 commits into from
Closed

Meteor 3 - wip #3

wants to merge 10 commits into from

Conversation

filipenevola
Copy link
Contributor

@filipenevola filipenevola commented Nov 9, 2023

Tasks

  • Migrate schema usage of collection (from collection2)
  • Migrate collection2 server tests with puppeteer
  • Migrate collection2 client tests with puppeteer
    • Tests are not running, for they are running fine here
  • Migrate helpers
  • Migrate hooks

- missing to really migrate schema usage of collection (from collection2)
 - https://github.com/Meteor-Community-Packages/meteor-collection2/pull/443/files#diff-1bc97b15b1e837743f590899c1c0fd36eab5a1bf21df692490899220dca7b160

We still need to decide if we want to bring all the tests and support multiple versions of Meteor, probably only Meteor 3 support would be better
- Compatible with Meteor 3.0 (hooks and helpers are still not supported tho)
- Removes `definition` option (and types)
…/meteor-collection2/tree/master/tests

- Skipped eslint checks
- We still need to run the client tests but server is running fine (we removed a few as they were trying to test dummy stuff (like default options) but modifying the collection2 class object (our goal is to run this test in our repo https://github.com/Meteor-Community-Packages/meteor-collection2/actions/runs/6398509589/job/17368820251)
.versions Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package had Typescript pinned in version 4. Beta 6 updated Typescript to version 5. This is causing a conflict, and currently, it's possible to use this package with Beta 6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants