-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make go env vars static #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
would like to see the pull_request CI go green on this before merge... the lint failing on the previous PR didn't make it to running tests 😬 |
Yeah, I'm waiting for CI ;) |
The CI doesn't use go1.21 use it will be green 😄 |
well, at least we'd have more confidence it hadn't regressed something ;) |
I agree, it was just a joke because my PR that add go1.21 is still red 😢 https://github.com/ldez/go-ruleguard/actions/workflows/go.yml |
Looks good, so merging. |
Try to make the security linter happier: