Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make go env vars static #456

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 9, 2023

Try to make the security linter happier:

Error: internal/goenv/goenv.go:10:14: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
	out, err := exec.Command("go", append([]string{"env"}, varNames...)...).CombinedOutput()
	            ^

Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@liggitt
Copy link
Contributor Author

liggitt commented Aug 9, 2023

would like to see the pull_request CI go green on this before merge... the lint failing on the previous PR didn't make it to running tests 😬

@cristaloleg
Copy link
Collaborator

Yeah, I'm waiting for CI ;)

@ldez
Copy link
Contributor

ldez commented Aug 9, 2023

The CI doesn't use go1.21 use it will be green 😄

@liggitt
Copy link
Contributor Author

liggitt commented Aug 9, 2023

The CI doesn't use go1.21 use it will be green 😄

well, at least we'd have more confidence it hadn't regressed something ;)

@ldez
Copy link
Contributor

ldez commented Aug 9, 2023

well, at least we'd have more confidence it hadn't regressed something ;)

I agree, it was just a joke because my PR that add go1.21 is still red 😢 https://github.com/ldez/go-ruleguard/actions/workflows/go.yml

@cristaloleg
Copy link
Collaborator

Looks good, so merging.

@cristaloleg cristaloleg merged commit 067b930 into quasilyte:master Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants