Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome - change back to --headless as default. #11885

Merged
merged 1 commit into from
Jan 17, 2025
+5 −1
Merged

chrome - change back to --headless as default. #11885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ All changes included in 1.7:
- ([#11441](https://github.com/quarto-dev/quarto-cli/issues/11441)): Don't add newlines around shortcodes during processing.
- ([#11643](https://github.com/quarto-dev/quarto-cli/issues/11643)): Improve highlighting of nested code block inside markdown code block, i.e. using ` ```{{python}} ` or ` ```python ` inside ` ````markdown` fenced code block.
- ([fb38eb5](https://github.com/quarto-dev/quarto-cli/commit/fb38eb56c11e09f44cef58fd3b697ff24bb5a3f3)) Use the `latest` parser for Acorn when analyzing JS code imported from OJS blocks.
- ([#10532](https://github.com/quarto-dev/quarto-cli/issues/10532)): Quarto changed default of `--headless=old` to `--headless` as [Chrome 132 has removed old headless mode](https://developer.chrome.com/blog/removing-headless-old-from-chrome) and only support new mode. For using old mode, `QUARTO_CHROMIUM` could be set to a [new `chrome-headless-shell` binary](https://developer.chrome.com/blog/chrome-headless-shell) or too an older chrome version (between 128 and 132) and `QUARTO_CHROMIUM_HEADLESS_MODE` set to `old` for using old headless mode with that compatabitle version.
5 changes: 4 additions & 1 deletion src/core/cri/cri.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function criClient(appPath?: string, port?: number) {
const app: string = appPath || await getBrowserExecutablePath();

// Allow to adapt the headless mode depending on the Chrome version
const headlessMode = getenv("QUARTO_CHROMIUM_HEADLESS_MODE", "old");
const headlessMode = getenv("QUARTO_CHROMIUM_HEADLESS_MODE", "none");

const cmd = [
app,
Expand All @@ -97,6 +97,9 @@ export async function criClient(appPath?: string, port?: number) {
// move to the new mode. We'll use `--headless=old` as the default for now
// until the new mode is more stable, or until we really pin a version as default to be used.
// This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
// EDIT: 17/01/2025 - old mode is gone in Chrome 132. Let's default to new mode to unbreak things.
// Best course of action is to pin a version of Chrome and use the chrome-headless-shell more adapted to our need.
// ref: https://developer.chrome.com/blog/chrome-headless-shell
`--headless${headlessMode == "none" ? "" : "=" + headlessMode}`,
"--no-sandbox",
"--disable-gpu",
Expand Down
Loading