typst brand yaml: translate named css font weights to typst #11779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from css to typst fixes #11726 also, we were previously failing if brand.typography.headings.weight was a string because it wouldn't be quoted so use a raw typst inline as with color
gordonwoodhull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11726
CSS has synonyms and it also uses dashes, so map and remove.
Also, we were previously failing if
brand.typography.headings.weightwas a string because it wouldn't be quoted. So use a raw typst inline (as with color).This will be a backport to 1.6 and I'll add the changelog there.