Add synonyms filter to the analysis configuration #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Dec 8, 2023
src/test/java/io/quarkus/search/app/SynonymSearchServiceTest.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
i59-add-synonyms
branch
from
1a3f256 to
9428d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #59
I've tried what I thought would be a simpler first step and added a synonyms filter.
Adding it to the index analyzer occasionally results in some strange highlights, so I've added it to the search analyzer, as the
synonym_graphis intended for the search analyzers, and it is supposed to work with multi-word synonyms that we have.Note the change to the search query,
simpleQueryStringmesses things up with synonyms, similar to what I've seen with the stop words in the other PR...