-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexing of Quarkiverse guide content #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
i54-quarkiverse
branch
from
November 22, 2023 09:11
c60b83e
to
06569d1
Compare
yrodiere
force-pushed
the
i54-quarkiverse
branch
from
November 22, 2023 09:41
06569d1
to
33dd203
Compare
#50 was just merged, so I rebased this one and force-pushed. |
yrodiere
reviewed
Nov 22, 2023
src/main/java/io/quarkus/search/app/yml/QuarkiverseMetadata.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
i54-quarkiverse
branch
from
November 30, 2023 12:27
33dd203
to
423dbaa
Compare
marko-bekhta
commented
Nov 30, 2023
yrodiere
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good overall but I noticed a few things
marko-bekhta
force-pushed
the
i54-quarkiverse
branch
from
November 30, 2023 15:05
423dbaa
to
e01322f
Compare
yrodiere
approved these changes
Nov 30, 2023
Save prefetched online guides into tmp files Prefetch remote guides before processing them so that they won't fail during indexing and causing more entities to not being indexed Boost Quarkus posts over quarkiverse ones Add Quarkiverse metadata parsing
yrodiere
force-pushed
the
i54-quarkiverse
branch
from
November 30, 2023 15:26
e01322f
to
eb3ddb7
Compare
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54
opening as a draft as this one is based on #50