Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing of Quarkiverse guide content #57

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

marko-bekhta
Copy link
Collaborator

fixes #54

opening as a draft as this one is based on #50

@yrodiere
Copy link
Member

#50 was just merged, so I rebased this one and force-pushed.

@yrodiere yrodiere self-requested a review November 22, 2023 09:41
@yrodiere yrodiere marked this pull request as ready for review November 22, 2023 09:41
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good overall but I noticed a few things

Save prefetched online guides into tmp files

Prefetch remote guides before processing them

so that they won't fail during indexing and causing more entities to not being indexed

Boost Quarkus posts over quarkiverse ones

Add Quarkiverse metadata parsing
@yrodiere
Copy link
Member

LGTM, thanks!

@yrodiere yrodiere merged commit f722e2b into quarkusio:main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing of Quarkiverse guide content
3 participants