Deploy to production #331
Merged
Deploy to production #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the quarkus group with 3 updates: [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus), [io.quarkus:quarkus-ide-config](https://github.com/quarkusio/quarkus) and io.quarkus:quarkus-maven-plugin. Updates `io.quarkus:quarkus-bom` from 3.13.2 to 3.14.0 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.13.2...3.14.0) Updates `io.quarkus:quarkus-ide-config` from 3.13.2 to 3.14.0 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.13.2...3.14.0) Updates `io.quarkus:quarkus-maven-plugin` from 3.13.2 to 3.14.0 Updates `io.quarkus:quarkus-ide-config` from 3.13.2 to 3.14.0 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.13.2...3.14.0) Updates `io.quarkus:quarkus-maven-plugin` from 3.13.2 to 3.14.0 --- updated-dependencies: - dependency-name: io.quarkus:quarkus-bom dependency-type: direct:production update-type: version-update:semver-minor dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: quarkus ... Signed-off-by: dependabot[bot] <[email protected]>
…6f147 Bump the quarkus group with 3 updates
Bumps the maven-plugins group with 1 update: [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire). Updates `org.apache.maven.plugins:maven-surefire-plugin` from 3.4.0 to 3.5.0 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.4.0...surefire-3.5.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: maven-plugins ... Signed-off-by: dependabot[bot] <[email protected]>
…-2d4c304164 Bump org.apache.maven.plugins:maven-surefire-plugin from 3.4.0 to 3.5.0 in the maven-plugins group
Bumps the quarkus group with 3 updates: [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus), [io.quarkus:quarkus-ide-config](https://github.com/quarkusio/quarkus) and io.quarkus:quarkus-maven-plugin. Updates `io.quarkus:quarkus-bom` from 3.14.0 to 3.14.1 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.0...3.14.1) Updates `io.quarkus:quarkus-ide-config` from 3.14.0 to 3.14.1 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.0...3.14.1) Updates `io.quarkus:quarkus-maven-plugin` from 3.14.0 to 3.14.1 Updates `io.quarkus:quarkus-ide-config` from 3.14.0 to 3.14.1 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.0...3.14.1) Updates `io.quarkus:quarkus-maven-plugin` from 3.14.0 to 3.14.1 --- updated-dependencies: - dependency-name: io.quarkus:quarkus-bom dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus ... Signed-off-by: dependabot[bot] <[email protected]>
…a3f5c Bump the quarkus group with 3 updates
Use single-valued highlighting where possible
Bumps the quarkus group with 5 updates: | Package | From | To | | --- | --- | --- | | [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | `3.14.1` | `3.14.2` | | [io.quarkus:quarkus-ide-config](https://github.com/quarkusio/quarkus) | `3.14.1` | `3.14.2` | | io.quarkus:quarkus-maven-plugin | `3.14.1` | `3.14.2` | | [io.quarkiverse.jgit:quarkus-jgit](https://github.com/quarkiverse/quarkus-jgit) | `3.1.2` | `3.1.3` | | [io.quarkiverse.web-bundler:quarkus-web-bundler](https://github.com/quarkiverse/quarkus-web-bundler) | `1.7.0` | `1.7.1` | Updates `io.quarkus:quarkus-bom` from 3.14.1 to 3.14.2 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.1...3.14.2) Updates `io.quarkus:quarkus-ide-config` from 3.14.1 to 3.14.2 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.1...3.14.2) Updates `io.quarkus:quarkus-maven-plugin` from 3.14.1 to 3.14.2 Updates `io.quarkiverse.jgit:quarkus-jgit` from 3.1.2 to 3.1.3 - [Release notes](https://github.com/quarkiverse/quarkus-jgit/releases) - [Commits](quarkiverse/quarkus-jgit@3.1.2...3.1.3) Updates `io.quarkiverse.web-bundler:quarkus-web-bundler` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/quarkiverse/quarkus-web-bundler/releases) - [Commits](quarkiverse/quarkus-web-bundler@1.7.0...1.7.1) Updates `io.quarkus:quarkus-ide-config` from 3.14.1 to 3.14.2 - [Release notes](https://github.com/quarkusio/quarkus/releases) - [Commits](quarkusio/quarkus@3.14.1...3.14.2) Updates `io.quarkus:quarkus-maven-plugin` from 3.14.1 to 3.14.2 --- updated-dependencies: - dependency-name: io.quarkus:quarkus-bom dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkiverse.jgit:quarkus-jgit dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkiverse.web-bundler:quarkus-web-bundler dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-ide-config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: quarkus ... Signed-off-by: dependabot[bot] <[email protected]>
…7cdcb Bump the quarkus group with 5 updates
Bumps the maven-plugins group with 1 update: net.revelc.code:impsort-maven-plugin. Updates `net.revelc.code:impsort-maven-plugin` from 1.11.0 to 1.12.0 --- updated-dependencies: - dependency-name: net.revelc.code:impsort-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: maven-plugins ... Signed-off-by: dependabot[bot] <[email protected]>
…-5f2ddbe9ef Bump net.revelc.code:impsort-maven-plugin from 1.11.0 to 1.12.0 in the maven-plugins group
First because it's not strictly necessary, as the BM25 scoring we use (the default) takes inverse document frequency into account, so that a stopword is much less likely to impact the score. Second, because we require all terms given by the user to match, so stopwords won't add a gazillion more matching documents. And third, because removing stopwords leads to strange behavior with the fast-vector highlighter. Note I kept the cn/ja stopwords removers, because those seem to do more than remove stopwords. Without them, I got highlighting on commas, for example...
In particular, avoid over-specific assertions that test more than what we're interested in.
In practice that was already more or less the case, but this ensure things will remain aligned if we change them in prod.
Because the previous settings used to trip circuit breakers in OpenSearch due to lack of memory to put all the pending documents on the heap. Note dev and prod relying on the same settings, with the same amount of heap given to OpenSearch.
Use fast-vector highlighting and force-merge after indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to fast-vector-highlighter doesn't seem to break anything, so let's see if it improves performance in prod.