Avoid indexing duplicate documents for Quarkiverse guides that are not translated #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
changed the title
…t translated We can use a single document for those. For now we still duplicate Quarkiverse guides per Quarkus version, but we could probably get rid of that too if we were to: * Take metadata for those guides from a version-independent source (e.g. the Quarkiverse docs GitHub repo). * AND allow search results on quarkus.io to return Quarkiverse guides independently from whether they are referenced in quarkus.yaml/quarkiverse.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use a single document for those.
Currently this doesn't bring much: before this patch we indexed 6671 documents, after it we index 6335 documents.
But if we're going to index many more Quarkiverse guides (#143 ), this may help.
Also, for now we still duplicate Quarkiverse guides per Quarkus version, but we could probably get rid of that too if we were to solve #143 by:
the Quarkiverse docs GitHub repo).
independently from whether they are referenced in
quarkus.yaml/quarkiverse.yaml.