Accept quotes for phrase matching in a query #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
i103-enable-phrase-query-syntax
branch
2 times, most recently
from
938c25d to
bd96522
Compare
yrodiere
force-pushed
the
i103-enable-phrase-query-syntax
branch
from
bd96522 to
7d9e543
Compare
yrodiere
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like it worked fine 😃
Note that the highlighted text still has each word wrapped on its own. We can try switching to a fast vector highlighter, which should be able to better wrap a few words in the same tags, but unless we reallyyyyyy need that I'd stay on a unified one 😃