Merge pull request #312 from marko-bekhta/standalone-mapper-cleanup

Some minor cleanups around the loading binder
quarkusio · Jul 31, 2024 · 5a2133e · 5a2133e
2 parents 3544b4a + a5cddc7
commit 5a2133e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/src/main/java/io/quarkus/search/app/entity/Guide.java b/src/main/java/io/quarkus/search/app/entity/Guide.java
@@ -6,6 +6,7 @@
 import java.util.Set;
 
 import io.quarkus.search.app.hibernate.AnalysisConfigurer;
+import io.quarkus.search.app.hibernate.GuideLoadingBinder;
 import io.quarkus.search.app.hibernate.I18nFullTextField;
 import io.quarkus.search.app.hibernate.I18nKeywordField;
 import io.quarkus.search.app.hibernate.InputProvider;
@@ -27,7 +28,7 @@
 import org.hibernate.search.mapper.pojo.mapping.definition.annotation.KeywordField;
 import org.hibernate.search.mapper.pojo.mapping.definition.annotation.SearchEntity;
 
-@SearchEntity(loadingBinder = @EntityLoadingBinderRef(name = "guideLoadingBinder"))
+@SearchEntity(loadingBinder = @EntityLoadingBinderRef(type = GuideLoadingBinder.class))
 @Indexed(routingBinder = @RoutingBinderRef(type = QuarkusVersionAndLanguageRoutingBinder.class))
 public class Guide {
     @DocumentId

diff --git a/src/main/java/io/quarkus/search/app/hibernate/GuideLoadingBinder.java b/src/main/java/io/quarkus/search/app/hibernate/GuideLoadingBinder.java
@@ -2,9 +2,6 @@
 
 import java.util.List;
 
-import jakarta.enterprise.context.ApplicationScoped;
-import jakarta.inject.Named;
-
 import io.quarkus.search.app.entity.Guide;
 
 import org.hibernate.search.mapper.pojo.standalone.loading.LoadingTypeGroup;
@@ -17,8 +14,6 @@
 import org.hibernate.search.mapper.pojo.standalone.loading.binding.EntityLoadingBinder;
 import org.hibernate.search.mapper.pojo.standalone.loading.binding.EntityLoadingBindingContext;
 
-@ApplicationScoped
-@Named("guideLoadingBinder")
 public class GuideLoadingBinder implements EntityLoadingBinder {
 
     @Override

diff --git a/src/main/java/io/quarkus/search/app/hibernate/QuarkusIOLoadingContext.java b/src/main/java/io/quarkus/search/app/hibernate/QuarkusIOLoadingContext.java
@@ -26,7 +26,7 @@ public int size() {
         return -1;
     }
 
-    public synchronized List<Guide> nextBatch(int batchSize) {
+    public List<Guide> nextBatch(int batchSize) {
         List<Guide> list = new ArrayList<>();
         for (int i = 0; guides.hasNext() && i < batchSize; i++) {
             list.add(guides.next());