-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post: quarkus.search.io series - standalone mapper #2057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you. I added a few comments, but all minor (except maybe a typo in a diagram). Feel free to publish whenever you're ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to represent the "user" / application code in this diagram? Just to emphasize that the application deals with Hibernate Search directly.
You could also represent it in the other diagram, to show the application deals with Hibernate ORM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, yes. Btw if you put things in this order, you might be able to avoid crossing lines:
[User code]
[DB] <-> [ORM] -> [Search] <-> [Backend]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea 👍🏻 😃
pushed the updated version 😃
Thanks for reviewing! 😃🏆 |
Don't feel like you have to rush this for me, I'll be on PTO soon anyway 😎 |
d6d717c
to
b8c5537
Compare
b8c5537
to
51aacab
Compare
🙈 The PR is closed and the preview is expired. |
Great to see this merged, thanks @marko-bekhta . When you have some time (no rush), can you please add it to the list at https://hibernate.org/search/more-resources/, along with your other blog post? |
|
Hey hey @yrodiere 😃
I've drafted something while it was fresh on my mind after the migration to the standalone mapper. It seems like it could be an interesting topic to share. Pinging only to get it on your radar, but I don't think there is any rush on this one 😃