Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: quarkus.search.io series - standalone mapper #2057

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

marko-bekhta
Copy link
Contributor

Hey hey @yrodiere 😃

I've drafted something while it was fresh on my mind after the migration to the standalone mapper. It seems like it could be an interesting topic to share. Pinging only to get it on your radar, but I don't think there is any rush on this one 😃

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you. I added a few comments, but all minor (except maybe a typo in a diagram). Feel free to publish whenever you're ready.

_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to represent the "user" / application code in this diagram? Just to emphasize that the application deals with Hibernate Search directly.
You could also represent it in the other diagram, to show the application deals with Hibernate ORM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 yeah, how about something like:
search-orm

Copy link
Member

@yrodiere yrodiere Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, yes. Btw if you put things in this order, you might be able to avoid crossing lines:

          [User code]
                           
[DB] <-> [ORM] -> [Search] <-> [Backend]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍🏻 😃
pushed the updated version 😃

_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
_posts/2024-08-01-search-standalone-mapper.adoc Outdated Show resolved Hide resolved
@marko-bekhta
Copy link
Contributor Author

Thanks for reviewing! 😃🏆
Let me finish some Validator work first and I'll get to addressing the suggestions! 😃

@yrodiere
Copy link
Member

Thanks for reviewing! 😃🏆 Let me finish some Validator work first and I'll get to addressing the suggestions! 😃

Don't feel like you have to rush this for me, I'll be on PTO soon anyway 😎

@marko-bekhta marko-bekhta force-pushed the post/standalone-mapper branch 2 times, most recently from d6d717c to b8c5537 Compare July 31, 2024 06:44
@marko-bekhta marko-bekhta force-pushed the post/standalone-mapper branch from b8c5537 to 51aacab Compare August 1, 2024 07:11
@marko-bekhta marko-bekhta marked this pull request as ready for review August 1, 2024 07:12
@gsmet gsmet merged commit 9b54350 into quarkusio:main Aug 1, 2024
1 check passed
Copy link

github-actions bot commented Aug 1, 2024

🙈 The PR is closed and the preview is expired.

@yrodiere
Copy link
Member

yrodiere commented Aug 1, 2024

Great to see this merged, thanks @marko-bekhta . When you have some time (no rush), can you please add it to the list at https://hibernate.org/search/more-resources/, along with your other blog post?

@marko-bekhta
Copy link
Contributor Author

When you have some time (no rush), can you please add it to the list at https://hibernate.org/search/more-resources/, along with your other blog post?

will do 😃 and thanks @yrodiere @gsmet 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants