-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog about Leyden #2053
Blog about Leyden #2053
Conversation
439b1b6
to
db04198
Compare
🙈 The PR is closed and the preview is expired. |
8e62e14
to
e01139a
Compare
Pushed a final draft. IMO it's ready - but feedback welcome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice article. I added some minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this content is good but I feel it takes a lot of text to get any real info and its written in start as normal jvm mode and graalvm/native image things done in Quarkus wasn't around - its not like until 50-75% through that a reader gets a feel of what leyden actually is and it gets more concrete.
If the goal is to make Quarkus community aware of what leyden will bring/help and how it relate to them and how to try it today - I don't think this article will help in its current form.
Here is some suggestions on improving it:
- Move some of the observations upfront (repeating them is fine) and before all the details and make it relatable to the last 5 years jvm/graalvm usage before going into the deeper details.
- Call out how it relates/compares to native-image much sooner as you can assume that's the question on Quarkus user mind - how does this relate to current jjvm and nativeimage approaches in quarkus.
- consider moving all the technical details on how to try it out and give feedback to a section after th conclusions or potentially split this blog in two (one for why/what/status, another for how to play/explore)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! I added some comments
dd0db82
to
391d5d4
Compare
Thanks all! That was a lot of great feedback, took us a while to process it. @Delawen also added some nice new diagrams ! Pushed again to have a new preview to proofread. |
1c72826
to
5da598e
Compare
1418982
to
8b3292b
Compare
@gsmet (not to be merged yet) would this solution to have multiple authors be acceptable?
All: it's an early draft - general feedback welcome but don't merge it.