re-arrange proposed video and content into two columns #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #1784 |
|
🎊 PR Preview 561455c has been successfully built and deployed to https://quarkus-site-pr-2041-preview.surge.sh
|
|
would it make sense to center the text and video rather than split in half? |
|
Nothing else is centered on the page, would seem out of place and awkward. We could flip the video and text boxes to put the whitespace on the right. |
gastaldi
reviewed
Aug 19, 2024
_includes/about.html
Outdated
| <img class="light-only" src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> | ||
| <img class="dark-only" src="{{site.baseurl}}/assets/images/about/icon-developerjoy-dark.svg"> | ||
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> |
There was a problem hiding this comment.
The icons do not show up in dark mode anymore
There was a problem hiding this comment.
Weird. Not sure how they were lost. I've updated.
There was a problem hiding this comment.
Hm, looks this PR now has content from #2080?
insectengine
force-pushed
the
AboutPage_alternative-video-layout
branch
from
4ea4bc6 to
941fe56
Compare
|
🙈 The PR is closed and the preview is expired. |
|
@insectengine can you rebase to we can merge it? |
- Provide the script that generate the wg.yaml - Create a workflow that update the working group yaml periodically - Add the wg page and layout - A bit of CSS to make the page looks ok
insectengine
force-pushed
the
AboutPage_alternative-video-layout
branch
from
941fe56 to
59d925a
Compare
cescoffier
approved these changes
Oct 28, 2024
|
@cescoffier - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Emmanuel's presentation video helps add historical context, but having it full width visually dominates all other content on the page. I suggest breaking the text and the video into columns to reduce this effect.