homepage image issue and footer issue #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix footer dark/light issue
|
🙈 The PR is closed and the preview is expired. |
cescoffier
reviewed
Jul 9, 2024
| @@ -5,7 +5,8 @@ | |||
| .homepage { | |||
|
|
|||
| background-image: url($baseurl + '/assets/images/bg-home-primary.png'); | |||
| background-repeat: no-repeat; | |||
| background-repeat: repeat-x; | |||
There was a problem hiding this comment.
Wouldn't round be better? Do you fear distortion?
There was a problem hiding this comment.
Not sure how Round would be a better solution. We have no need to repeat the image vertically and I've made the image seamlessly repeat on the X axis (while also making is smaller). This solves the issue for large screens and doesn't negatively impact mobile screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make homepage image repeatable horizontally and changed css to address large screen issues ( replaces fix: set homepage background size to 100% #2037)
fix coloring issue of icons in Red Hat footer (no visible in light mode).