Switch from Twitter to X #1995
Merged
Switch from Twitter to X #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix a few unrelated things.
gsmet
commented
Jun 4, 2024
| @@ -34,8 +34,8 @@ <h4>Quarkus Insights Podcast</h4> | |||
| </div> | |||
| <div class="width-3-12 width-12-12-m contrib-block"> | |||
| <img src="{{site.baseurl}}/assets/images/community/icon-twitter.png"> | |||
There was a problem hiding this comment.
We will need an image with the X logo.
| @@ -2,7 +2,7 @@ | |||
| <a class="share-linkedin" href="https://www.linkedin.com/shareArticle?mini=true&url={{ site.url }}{{ include.url }}&title={{ include.title }}" rel="nofollow" target="_blank" title="Share on LinkedIn"> | |||
| <img src="{{site.baseurl}}/assets/images/share-page/icons_social-linkedin.png"/> | |||
| </a> | |||
| <a class="share-twitter" href="https://twitter.com/intent/tweet?text={{ include.title }}&url={{ site.url }}{{ include.url }}&via={{ site.twitter_username }}&related={{ site.twitter_username }}" rel="nofollow" target="_blank" title="Share on Twitter"> | |||
| <a class="share-x" href="https://x.com/intent/tweet?text={{ include.title }}&url={{ site.url }}{{ include.url }}&via={{ site.twitter_username }}&related={{ site.twitter_username }}" rel="nofollow" target="_blank" title="Share on X"> | |||
| <img src="{{site.baseurl}}/assets/images/share-page/icons_social-twitter.png"/> | |||
| @@ -17,7 +17,7 @@ | |||
| <div class="width-3-12 width-0-12-m"></div> | |||
| <div class="width-3-12 width-0-12-m"></div> | |||
| <div class="width-6-12 width-12-12-m"> | |||
| <a href="http://www.twitter.com/@quarkusio" class="button-cta"><i class="fab fa-twitter"></i>Follow us on Twitter</a> | |||
| <a href="https://x.com/@quarkusio" class="button-cta"><i class="fab fa-twitter"></i>Follow us on X</a> | |||
There was a problem hiding this comment.
Unfortunately, FA 5 doesn't support X so we would have to move to FA 6.
Not sure the update will be straightforward and we need to make sure we can still use it for free.
|
🙈 The PR is closed and the preview is expired. |
|
I merged this first step, I will let @insectengine address the comments above when he has some time. |
|
Thanks... looking into the switch to FA 6 to remove the need of images and pruning unused includes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a few unrelated things.
** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **