Extract texts from templates #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
ynojima
force-pushed
the
extract-texts-from-templates
branch
from
89ddbef to
d317304
Compare
While localization repositories extracts texts from .adoc and .md files with po4a utility, po4a cannot extract texts from html template files as they contains template directives, which is not valid html tag. To localize texts in html template files, localization repositories have whole html template file instead of just extracted texts. See: https://github.com/quarkusio/ja.quarkus.io/tree/main/l10n/override/ja_JP This impacts maintenability of lozalization repositories because once original html template files are updated, localized html template files need to be updated even when it doesn't contain texts change. This commit extracts texts from html template files to yaml files. Once this change is introduced, localization repositories can process yaml files with po4a.
ynojima
force-pushed
the
extract-texts-from-templates
branch
from
d317304 to
ca8a5ef
Compare
|
@ynojima sorry for the delay, I will have a look soon. I totally agree we should do this. |
|
Thank you! I merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1990
While localization repositories extracts texts from .adoc and .md files with po4a utility, po4a cannot extract texts from html template files as they contains template directives, which is not valid html tag. To localize texts in html template files, localization repositories have whole html template file instead of just extracted texts. See: https://github.com/quarkusio/ja.quarkus.io/tree/main/l10n/override/ja_JP
This impacts maintenability of lozalization repositories because once original html template files are updated, localized html template files need to be updated even when it doesn't contain texts change.
This commit extracts texts from html template files to yaml files. Once this change is introduced, localization repositories can process yaml files with po4a.