Darkmode #1908
Merged
Darkmode #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
|
Noted, will work on this for the extensions sub-site! |
gastaldi
reviewed
Mar 6, 2024
| @@ -9,22 +9,34 @@ <h2>Open Source Utterly and Absolutely</h2> | |||
| <h2>What Makes Quarkus Different?</h2> | |||
| </div> | |||
| <div class="width-3-12 width-12-12-m"> | |||
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> | |||
| <picture> | |||
| <source srcset="{{site.baseurl}}/assets/images/about/icon-developerjoy-dark.svg" media="(prefers-color-scheme:dark)"> | |||
There was a problem hiding this comment.
Suggested change
| <source srcset="{{site.baseurl}}/assets/images/about/icon-developerjoy-dark.svg" media="(prefers-color-scheme:dark)"> | |
| <source srcset="{{site.baseurl}}/assets/images/about/icon-developerjoy-dark.svg" media="(prefers-color-scheme:dark)" /> |
gastaldi
reviewed
Mar 6, 2024
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> | ||
| <picture> | ||
| <source srcset="{{site.baseurl}}/assets/images/about/icon-developerjoy-dark.svg" media="(prefers-color-scheme:dark)"> | ||
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> |
There was a problem hiding this comment.
Suggested change
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg"> | |
| <img src="{{site.baseurl}}/assets/images/about/icon-developerjoy.svg" /> |
This was referenced Mar 19, 2024
gsmet
force-pushed
the
darkmode
branch
2 times, most recently
from
765250b to
f74776f
Compare
|
I rebased to experiment with the preview fixes. |
This was referenced Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a clean dark mode for the site. To keep it simple, it detects the OS preference and sets the site via CSS.