Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blog post about Quarkus OIDC proxy #1905

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Add a blog post about Quarkus OIDC proxy #1905

merged 1 commit into from
Mar 27, 2024

Conversation

sberyozkin
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

😭 Deploy PR Preview failed.

@sberyozkin sberyozkin force-pushed the oidc_proxy_blog branch 2 times, most recently from ba1105e to bfee3b9 Compare March 2, 2024 21:51
maxandersen
maxandersen requested changes Mar 3, 2024
View reviewed changes
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
maxandersen
maxandersen previously requested changes Mar 3, 2024
View reviewed changes
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
@sberyozkin sberyozkin force-pushed the oidc_proxy_blog branch 6 times, most recently from 063de79 to 48a666a Compare March 5, 2024 19:01
@sberyozkin sberyozkin marked this pull request as ready for review March 5, 2024 19:06
@sberyozkin
Copy link
Member Author

sberyozkin commented Mar 5, 2024 •
edited
Loading

@maxandersen I've completed the first full edit of this blog post. Have a look please when you get a chance. If you have a Strava account then verifying this blog creating the same action can be good. Or, create your own action and use any other provider and see if the blog is of some help.

We'll tune this blog for the next few weeks for sure :-).

Small print: If you decide to verify it, note that the the moment quarkus-oidc-proxy is not released yet :-) So it will have to be built against Quarkus main and its version will also be 999-SNAPSHOT (instead of 0.1.0)

@sberyozkin sberyozkin force-pushed the oidc_proxy_blog branch 3 times, most recently from e5a21b2 to 3a68502 Compare March 12, 2024 19:31
@sberyozkin
Copy link
Member Author

Tested with the docker-compose up, fixed some image resolution bugs and a few typos, added a note it relies on 3.9.0. Looking not too bad

@sberyozkin sberyozkin force-pushed the oidc_proxy_blog branch 2 times, most recently from 58d00e3 to c5632ed Compare March 18, 2024 22:35
cescoffier
cescoffier previously requested changes Mar 19, 2024
View reviewed changes
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
_posts/2024-04-01-oidc-proxy.adoc Outdated Show resolved Hide resolved
@cescoffier
Copy link
Member

It's a great article. A bit too long. Is there anything we can remove (move to the doc).

@sberyozkin
Copy link
Member Author

@cescoffier Thanks for your time reviewing it and for adding some sparkle to the text, I've applied all the suggestions with only a few tiny edits, let me clean it all up now

@sberyozkin
Copy link
Member Author

@cescoffier I've removed about 5 images, hopefully it will make it a bit shorter

@sberyozkin
Copy link
Member Author

@cescoffier @maxandersen I've applied Clement's suggestions with a few minor edits, and removed about 5 or 6 images which should also make the post a bit shorter. Have a look when you get a chance.

@sberyozkin
Copy link
Member Author

I'm not 100% sure I'm seeing all the suggestions, after refreshing this page I'm seeing 40 hidden messages, click on them, seeing 20 hidden messages, click on them - seeing 3 hidden message and finally I see that all the suggestions are resolved...

@sberyozkin sberyozkin dismissed stale reviews from cescoffier and maxandersen March 26, 2024 10:29

The propsed changes have been applied, thanks

@sberyozkin
Copy link
Member Author

sberyozkin commented Mar 26, 2024 •
edited
Loading

Hi @maxandersen @cescoffier Thanks for the review so far.
I've updated this PR to have it published tomorrow, if you won't have time to do another review/tests, then lets publish it and hopefully the users will test OIDC proxy with GPTs or custom SPAs and give us some feedback, thanks

@sberyozkin sberyozkin merged commit 6432733 into quarkusio:develop Mar 27, 2024
1 check passed
@sberyozkin sberyozkin deleted the oidc_proxy_blog branch March 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier left review comments

@maxandersen maxandersen maxandersen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @cescoffier @maxandersen