Post: quarkus.search.io series - rolling over #1898
Conversation
|
🙈 The PR is closed and the preview is expired. |
| link:https://github.com/quarkusio/search.quarkus.io/blob/d956b6a1341d8693fa1d6b7881f3840f48bdaacd/src/main/java/io/quarkus/search/app/indexing/Rollover.java#L44-L331[rollover implementation] | ||
| and link:https://github.com/quarkusio/search.quarkus.io/blob/d956b6a1341d8693fa1d6b7881f3840f48bdaacd/src/main/java/io/quarkus/search/app/indexing/IndexingService.java#L226-L244[rollover usage]. | ||
|
|
||
| Now, since we would want to keep our application providing results to any search operations and add/update documents to the indexes |
There was a problem hiding this comment.
I think you need to provide some context about how the documentation is indexed and the fact that you are mass indexing the documentation every time and not updating documents (which would be another approach and in this case you probably wouldn't need this approach).
marko-bekhta
force-pushed
the
post/search-quarkus-io-rollover
branch
from
1a30f0c to
ca2d700
Compare
|
Thanks Guillaume! I've tried to address your suggestions. |
There was a problem hiding this comment.
Looks great! I'm curious: what did you use for the drawings?
I added a few suggestions below, feel free to pick what you agree with.
On important thing though: the feature request for rollover already exists, it's https://hibernate.atlassian.net/browse/HSEARCH-3499 . I added suggestions accordingly.
marko-bekhta
force-pushed
the
post/search-quarkus-io-rollover
branch
from
ca2d700 to
7a23b79
Compare
|
Yoann, thanks for the suggestions! I've applied them all (at least I think I did 😄) as for the drawing tool, I was trying out this one https://excalidraw.com/ |
|
I'll let you decide on the date when you'd like to publish this one 😃 |
|
Thanks. Well then, seems we're ready to merge? We'll just need to agree on a date so that @marko-bekhta can update the post's metadata before we merge. @gsmet is there some process or is anyone free to post whenever they like? |
|
You can post whenever you like. Thursday is OK. I don't recommend Monday or Friday. I was told around posting around 3PM was the best (if you plan on tweeting about it). I can either retweet or tweet (if you write something for me) with the QuarkusIO account if you'd like. But please ping me on Zulip when the blog post is published so that I don't have to monitor things :). |
|
@marko-bekhta today 3PM then? |
|
Obviously you can push the blog post earlier. 3PM is more about when we should tweet. |
marko-bekhta
force-pushed
the
post/search-quarkus-io-rollover
branch
from
7a23b79 to
a7f909c
Compare
Updated the file name and the date. |
|
Merged, thanks. @marko-bekhta I'll let you tweet about this and/or provide Guillaume with a tweet for the |
@yrodiere here it is 😃 🙈