Use qs web component

[ia3andy]

This is a draft until I come back from PTOs

It mostly need CSS cleaning to be ready..

The search service needs to be started locally, and it might require some change in the Chrome config to allow cors on localhost.

[ia3andy]

This needs: quarkusio/search.quarkus.io#58

[yrodiere]

Thanks. I added a few comments below.

[github-actions]

🙈 The PR is closed and the preview is expired.

[gsmet]

I rebased to fix a conflict and the preview should work.

[ia3andy]

Ok it works and can be tested in the preview 🥳
cc @marko-bekhta @yrodiere

[yrodiere]

Thanks Andy.

I noticed a few things:

1. The ellipses ("...") seem to be gone in the excerpts from the content:
   
   
2. Selecting version "3.8" or earlier leads to a 404... but maybe that's just a limitation of the preview? Regardless, I wasn't able to test the "old" guide list.
3. If you go to https://quarkus-site-pr-1895-preview.surge.sh/guides/ , then select version "Main - Snapshot", then click "back" to go to the previous page in your browser... the list displays a search, for some reason, instead of just the default display by guide type (tutorial/etc.). The value of the drop-down also doesn't get reverted, but that seems to be a pre-existing bug. The first problem isn't, though.
   
4. Calls to the search backend appear to be twice as numerous as before: first an OPTIONS call, then a GET call. And that's not just the first call either, but every single call. Is that on purpose? The existing version only does a GET call.
   Note that we sometimes have serious latency problems on this cluster, so doubling the number of calls could have dramatic impact...
   

[marko-bekhta]

One more thing 🙈 if a user tries to search for something and then deletes the search text a never-ending-spinner is displayed:

[ia3andy]

@yrodiere https://stackoverflow.com/questions/29954037/why-is-an-options-request-sent-and-can-i-disable-it

[ia3andy]

@marko-bekhta good catch, I never experienced it because there is no latency locally :)

[yrodiere]

@yrodiere https://stackoverflow.com/questions/29954037/why-is-an-options-request-sent-and-can-i-disable-it

Thanks, but we didn't experience that before, so surely there's been a change that triggers it. Is that change worth doubling the latency?

[ia3andy]

Ok this should fix most of the issues you experienced:
https://github.com/quarkusio/search.quarkus.io/pull/222/files

[ia3andy]

For the ..., I think it should be done by the api instead if that's possible?

[ia3andy]

@yrodiere @marko-bekhta could you give it a new try, and if it's good we can merge :)

[yrodiere]

The ellipses ("...") seem to be gone in the excerpts from the content:

Will be fixed in quarkusio/search.quarkus.io#223 , thanks @marko-bekhta .

If you go to https://quarkus-site-pr-1895-preview.surge.sh/guides/ , then select version "Main - Snapshot", then click "back" to go to the previous page in your browser... the list displays a search, for some reason, instead of just the default display by guide type (tutorial/etc.). The value of the drop-down also doesn't get reverted, but that seems to be a pre-existing bug. The first problem isn't, though.

Still the same problem:
Screencast from 2024-04-08 15-23-22.webm

Selecting version "3.8" or earlier leads to a 404... but maybe that's just a limitation of the preview? Regardless, I wasn't able to test the "old" guide list.

Still the same problem -- is this just a limitation of the preview? Did you test "old" guide lists locally, e.g. the one for 2.7?

Calls to the search backend appear to be twice as numerous as before: first an OPTIONS call, then a GET call

Fixed, thanks.

[ia3andy]

The ellipses ("...") seem to be gone in the excerpts from the content:

Will be fixed in quarkusio/search.quarkus.io#223 , thanks @marko-bekhta .

🙏

If you go to https://quarkus-site-pr-1895-preview.surge.sh/guides/ , then select version "Main - Snapshot", then click "back" to go to the previous page in your browser... the list displays a search, for some reason, instead of just the default display by guide type (tutorial/etc.). The value of the drop-down also doesn't get reverted, but that seems to be a pre-existing bug. The first problem isn't, though.

Still the same problem: Screencast from 2024-04-08 15-23-22.webm

I can't reproduce this issue because I suspect it's a latency issue. I have a good idea of why: the search form detects the change which starts a search, and then loads the page. I have a fix and I created a PR for it on search.quarkus.io

Selecting version "3.8" or earlier leads to a 404... but maybe that's just a limitation of the preview? Regardless, I wasn't able to test the "old" guide list.

Yes I tested it locally and it works fine

Still the same problem -- is this just a limitation of the preview? Did you test "old" guide lists locally, e.g. the one for 2.7?

Calls to the search backend appear to be twice as numerous as before: first an OPTIONS call, then a GET call

Fixed, thanks.

yeahh!

[ia3andy]

@yrodiere so when the latest PR is in prod, we can merge this right?

[yrodiere]

If you go to https://quarkus-site-pr-1895-preview.surge.sh/guides/ , then select version "Main - Snapshot", then click "back" to go to the previous page in your browser... the list displays a search, for some reason, instead of just the default display by guide type (tutorial/etc.). The value of the drop-down also doesn't get reverted, but that seems to be a pre-existing bug. The first problem isn't, though.

Still the same problem: Screencast from 2024-04-08 15-23-22.webm

I can't reproduce this issue because I suspect it's a latency issue. I have a good idea of why: the search form detects the change which starts a search, and then loads the page. I have a fix and I created a PR for it on search.quarkus.io

Seems to work now, thanks

[yrodiere]

LGTM thanks; feel free to merge whenever you have time to handle the possible consequences :)

[ia3andy]

🤞