Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve landing page mobile responsiveness #1864

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Improve landing page mobile responsiveness #1864

merged 2 commits into from
Jan 15, 2024

Conversation

bbambozzi
Copy link
Contributor

Fixes

Enhancements

  • Adds more media queries for a smoother mobile presentation.

@gsmet gsmet requested a review from insectengine January 4, 2024 08:08
insectengine
insectengine requested changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@insectengine insectengine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I'd on suggest matching the line-height to the font size for consistency in experience.

< 1024px : 5rem/5rem
< 768px : 5rem/5rem
< 550px : 3.8rem/3.8rem
< 425px : 3rem/3rem
< 375px : 2.8rem/2.8rem
<320ps : 2.5rem/2.5rem

@gsmet gsmet merged commit 17d9d9a into quarkusio:develop Jan 15, 2024
1 check passed
@gsmet
Copy link
Member

gsmet commented Jan 15, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@insectengine insectengine insectengine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hero Band Text Overflows on Mobile Screens (<= 425px width)
3 participants
@bbambozzi @gsmet @insectengine