Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect quarkus.analytics.disabled boolean value #1849

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix incorrect quarkus.analytics.disabled boolean value #1849

merged 1 commit into from
Dec 19, 2023

Conversation

gefloh
Copy link
Contributor

@gefloh gefloh commented Nov 30, 2023

The boolean value for quarkus.analytics.disabled is incorrect here. Fixes #1736 .

@gefloh
Copy link
Contributor Author

gefloh commented Dec 4, 2023

@gsmet can you have a quick look? This doesn't take long. Thanks.

gsmet
gsmet approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Your change looks good.

I think this is a bit confusing though and given the importance of it, we should clarify things. I'll have a closer look.

@gsmet gsmet merged commit e5bc30a into quarkusio:develop Dec 19, 2023
@gsmet
Copy link
Member

gsmet commented Dec 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong boolean value in Quarkus Analytics property example
2 participants
@gefloh @gsmet